[codex] Harden sweep cleanup follow-up - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #1 after Copilot/Claude review. This hardens sweep shutdown and instrument-output safety, fixes autosave error semantics, improves cleanup diagnostics, and adds targeted regression coverage for the review findings.
Key changes
SHUTDOWN_TIMEOUTand still force known AWG output off plus close known ports.AUTO_SAVE_FAILEDwarnings instead of converting a completed sweep intoSweepFailed.Validation
PYTHONPATH=src .venv/bin/python -m unittest discover -s tests-> 44 tests OKPYTHONPATH=src python3 -m unittest discover -s tests-> 44 tests OKPYTHONPATH=src .venv/bin/python -m compileall -q src tests-> OKpython3 -c 'import pathlib, tomllib; tomllib.loads(pathlib.Path("pyproject.toml").read_text())'-> OKgit diff --check-> OKapp.bootstrap.build_desktop_app()-> OK-pread-only regression review over runtime fixes -> clean-pread-only regression review over tests/docs/dependencies -> clean